[fix]: fixed edge case crash cases if notifications are processed nearly simultaneously #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ultaneously - closes #2944 - added more strict tsconfig to allow migrating single files to stricter rules
Apollon77
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the issue which is closed by this PR
Implementation details
In #2944 a controller crash occured if notifications were cleaned nearly simultaneously, and we only checked that the index is present at the beginning of the file and not re-checked after doing asynchronous operation. Hence, we added
noUncheckedIndexedAccessfor the tsconfig (onlycommonpackage) to avoid these cases.Tests
If no tests added, please specify why it was not possible
Not really possible, but we avoided these cases by adapting the tsconfig for adding
noUncheckedIndexedAccessrule for this file.